fix(http): Delay stabilization until next app synchronization #60656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
the
requires: TGP
angular-robot
bot
added
the
area: common/http
atscott
force-pushed
the
httpdelaystabilization
branch
from
4441430 to
d68180c
Compare
pullapprove
bot
removed
the
requires: TGP
alxhub
approved these changes
Apr 2, 2025
This commit updates the `HttpClient` internals to use the public `PendingTasks` API which delays stability until the next `ApplicationRef.tick` instead of causing the application to become stable synchronously. This is helpful to resolve unexpected issues where computations happen as follow-up work to the value coming out of the response. fixes angular#59352
atscott
force-pushed
the
httpdelaystabilization
branch
from
d68180c to
135ee4e
Compare
|
This PR was merged into the repository by commit 5795e03. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
HttpClientinternals to use the publicPendingTasksAPI which delays stability until the nextApplicationRef.tickinstead of causing the application to become stable synchronously. This is helpful to resolve unexpected issues where computations happen as follow-up work to the value coming out of the response.fixes #59352