fix(compiler-cli): wrong event name for host listener decorators (#60460)

crisbeto · pkozlowski-opensource · commit 2d51a203dc87 · 2025-03-19T19:05:44.000+01:00
Fixes that when generating the type checking code `@HostListener`, we were using the method name instead of the event name. PR Close #60460
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/src/host_bindings.ts b/packages/compiler-cli/src/ngtsc/typecheck/src/host_bindings.ts
@@ -341,7 +341,6 @@ function createNodeFromListenerDecorator(
   // manually here. Note that we use a dummy span with -1/-1 as offsets, because it isn't
   // used for type checking and constructing it accurately would take some effort.
   const span = new ParseSpan(-1, -1);
-  const [name, phase] = method.name.text.split('.');
   const argNodes: AST[] = [];
   const methodStart = method.getStart();
   const methodReceiver = new ThisReceiver(span, new AbsoluteSourceSpan(methodStart, methodStart));
@@ -387,17 +386,19 @@ function createNodeFromListenerDecorator(
   }
 
   const callNode = new Call(span, nameSpan, receiver, argNodes, span);
+  const eventNameNode = args[0];
+  const [eventName, phase] = eventNameNode.text.split('.');
 
   listeners.push(
     new TmplAstBoundEvent(
-      name,
-      name.startsWith('@') ? ParsedEventType.Animation : ParsedEventType.Regular,
+      eventName,
+      eventName.startsWith('@') ? ParsedEventType.Animation : ParsedEventType.Regular,
       callNode,
       null,
       phase,
       createSourceSpan(decorator),
       createSourceSpan(decorator),
-      createStaticExpressionSpan(method.name),
+      createStaticExpressionSpan(eventNameNode),
     ),
   );
 }
diff --git a/packages/compiler-cli/test/ngtsc/host_bindings_type_check_spec.ts b/packages/compiler-cli/test/ngtsc/host_bindings_type_check_spec.ts
@@ -506,7 +506,7 @@ runInEachFileSystem(() => {
       const diags = env.driveDiagnostics();
       expect(diags.length).toBe(1);
       expect(diags[0].messageText).toBe(
-        `Argument of type 'Event' is not assignable to parameter of type 'string'.`,
+        `Argument of type 'MouseEvent' is not assignable to parameter of type 'string'.`,
       );
       expect(getDiagnosticSourceCode(diags[0])).toBe('$event');
     });
