Content-Length: 356486 | pFad | https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5951

BED Re-generate library using kms/synth.py by dpebot · Pull Request #5951 · googleapis/google-cloud-python · GitHub
Skip to content

Re-generate library using kms/synth.py #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2018
Merged

Re-generate library using kms/synth.py #5951

merged 4 commits into from
Sep 12, 2018

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Sep 12, 2018

This PR was created by autosynth.

@dpebot dpebot requested a review from theacodes as a code owner September 12, 2018 12:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2018
tseaver
tseaver suggested changes Sep 12, 2018
View reviewed changes
kms/README.rst Outdated
.. _Google Cloud Key Management Service (KMS) API: https://cloud.google.com/kms
.. _Client Library Documentation: https://googlecloudplatform.github.io/google-cloud-python/latest/kms/index.html
.. _Cloud Key Management Service (KMS) API: https://cloud.google.com/kms
.. _Client Library Documentation: https://googlecloudplatform.github.io/google-cloud-python/stable/kms/usage.html

This comment was marked as spam.

Sign in to view

kms/README.rst Outdated
.. _Enable the Google Cloud Key Management Service (KMS) API.: https://cloud.google.com/kms
.. _Setup Authentication.: https://googlecloudplatform.github.io/google-cloud-python/latest/core/auth.html
.. _Enable the Cloud Key Management Service (KMS) API.: https://cloud.google.com/kms
.. _Setup Authentication.: https://googlecloudplatform.github.io/google-cloud-python/stable/core/auth.html

This comment was marked as spam.

Sign in to view

@tseaver tseaver added codegen api: cloudkms Issues related to the Cloud Key Management Service API. labels Sep 12, 2018
@theacodes
Copy link
Contributor

@tseaver do you mind updating the synth script to accommodate that?

@tseaver
Copy link
Contributor

tseaver commented Sep 12, 2018

@theacodes

do you mind updating the synth script to accommodate that?

If you'll promise to fix the templates to stop emitting stable/ links. :)

Do you want me to push the changes to kms/synth.py to the autosynth-kms branch, along with the resulting generated changes?

@theacodes
Copy link
Contributor

If you'll promise to fix the templates to stop emitting stable/ links. :)

File a bug on googleapis/gapic-generator and they should fix it. :)

Do you want me to push the changes to kms/synth.py to the autosynth-kms branch, along with the resulting generated changes?

Yes, DPE bot won't mess with the PR.

@tseaver

This comment has been minimized.

Sign in to view
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 12, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 12, 2018

Looks like googleapis/googleapis@7696d3c landed after @dpebot did the codegen.

@tseaver tseaver merged commit 4e1147b into master Sep 12, 2018
@tseaver tseaver deleted the autosynth-kms branch September 12, 2018 18:51
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dpebot @tseaver
Re-generate library using kms/synth.py (#5951)
d6773f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: cloudkms Issues related to the Cloud Key Management Service API. cla: no This human has *not* signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpebot @theacodes @tseaver @googlebot








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5951

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy