-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-87390: Add tests demonstrating current type variable substitution behaviour #32341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f508d12
Add integration tests for type variable substitution
mrahtz ea104b9
Add tests for list, dict and tuple
mrahtz 526d9e8
Add tests for Tuple
mrahtz 0f022db
Revert "Add tests for Tuple"
mrahtz cc7bf8c
Make it easier to tests all tuple, list and dict types
mrahtz 458b5dd
TypeVarSubstitutionTests -> GenericAliasSubstitutionTests
mrahtz 0c8ba38
Remove question marks from cases I'm actually pretty sure about
mrahtz db24e70
Note that list[] should only take one argument
mrahtz 15a4809
Leave unpacked tuples unsimplified
mrahtz 0d7d2eb
Add generic[*Ts][*tuple[*Ts]]
mrahtz ab01c8a
Update comments based on decision to leave unpacked tuples unsimplified
mrahtz c4fe922
Add tests for generic[T1, bool, T2][*tuple[int, str]]
mrahtz d55b8fb
Update comments based on decision to unpack *some* tuples
mrahtz e858fc6
Note that generic[*tuple[()]] should raise TypeError
mrahtz 3bc7d26
Note that C[T, *tuple[int, ...]][int] raises TypeError only because C…
mrahtz c980e4f
State that multiple unpackings should be allowed where possible
mrahtz 95b7210
Add test for generic[T1, *tuple[int, ...], T2][str, bool, float]
mrahtz 96394b1
Update comments according to revised tentative spec at https://github…
mrahtz ed9a557
Update expected comments to account for unpacked types only being val…
mrahtz faa9fc3
Merge branch 'main' into subst-tests
mrahtz 9947fc0
Update to reflect results after merging latest main
mrahtz 12496fc
Update ALL tests to reflect results after merging latest main
mrahtz db9af53
Remove comments saying we should get a TypeError in cases where we *d…
mrahtz c5b5a63
Update comments on expected results based on latest tentative spec at…
mrahtz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Note that generic[*tuple[()]] should raise TypeError
- Loading branch information
commit e858fc6af418027f850a505333dd88f1751ff75d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.