Content-Length: 385224 | pFad | http://github.com/kubernetes/kubernetes/pull/131975/#start-of-content

0D WIP: kubectl: Fix in-cluster config not loaded with certain flags specified by tchap · Pull Request #131975 · kubernetes/kubernetes · GitHub
Skip to content

WIP: kubectl: Fix in-cluster config not loaded with certain flags specified #131975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: kubectl: Fix in-cluster config not loaded with certain flags specified #131975

wants to merge 1 commit into from

Conversation

tchap
Copy link
Contributor

@tchap tchap commented May 26, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubectl now disables in-cluster config altogether when certain flags are specified, like --request-timeout. This is not happening any more and in-cluster config is enabled even though some overrides are specified.

Which issue(s) this PR fixes:

Fixes #49343
Fixes #93474

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 26, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @tchap. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and skitt May 26, 2025 22:54
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign smarterclayton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 26, 2025
@tchap
Copy link
Contributor Author

tchap commented May 26, 2025

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label May 26, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI May 26, 2025
@tchap tchap force-pushed the kubectl-incluster-flags branch from 80e882b to 58ea7d6 Compare May 26, 2025 23:00
@tchap tchap marked this pull request as ready for review May 27, 2025 06:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and soltysh May 27, 2025 06:35
@ardaguclu
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2025
@tchap tchap changed the title kubectl: Fix in-cluster config not loaded with certain flags specified WIP: kubectl: Fix in-cluster config not loaded with certain flags specified May 27, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@tchap tchap force-pushed the kubectl-incluster-flags branch from 58ea7d6 to 2b9d84b Compare May 27, 2025 14:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2025
@tchap tchap force-pushed the kubectl-incluster-flags branch 3 times, most recently from e2aa820 to 6b34c38 Compare May 30, 2025 11:42
@tchap
kubectl: Fix in-cluster config not loaded on flags
a84178b 
In-cluster config is now being skipped when certain command line flags
are specified, like --request-timeout. This is now fixed and in-cluster
config is loaded even when such a flag is specified.
@tchap tchap force-pushed the kubectl-incluster-flags branch from 6b34c38 to a84178b Compare May 30, 2025 11:48
@k8s-ci-robot
Copy link
Contributor

@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind a84178b link true /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6 a84178b link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-gce a84178b link true /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@skitt skitt Awaiting requested review from skitt

@aojea aojea Awaiting requested review from aojea

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
3 participants
@tchap @k8s-ci-robot @ardaguclu








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/kubernetes/kubernetes/pull/131975/#start-of-content

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy