Content-Length: 696800 | pFad | http://github.com/NVIDIA/TensorRT-LLM/issues/4858

53C [feat] Support XQA-based MLA on SM120 by jinyangyuan-nvidia · Pull Request #4858 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

[feat] Support XQA-based MLA on SM120 #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jinyangyuan-nvidia
Copy link
Collaborator

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7305 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7305 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5293 completed with status: 'FAILURE'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7325 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7325 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5309 completed with status: 'FAILURE'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7351 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7351 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5327 completed with status: 'FAILURE'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7369 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7369 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5344 completed with status: 'FAILURE'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7406 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7406 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5372 completed with status: 'ABORTED'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7410 [ run ] triggered by Bot

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7425 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7410 [ run ] completed with state ABORTED
/LLM/main/L0_MergeRequest_PR pipeline #5375 completed with status: 'FAILURE'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7437 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7425 [ run ] completed with state ABORTED

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7744 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7693 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7744 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 8bf4200

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7746 [ run ] triggered by Bot

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot kill

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7763 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7746 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7764 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7763 [ kill ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7764 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5623 completed with status: 'FAILURE'

@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7803 [ run ] triggered by Bot

@ming-wei ming-wei requested a review from lowsfer June 6, 2025 02:28
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7803 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5651 completed with status: 'SUCCESS'

lowsfer and others added 2 commits June 6, 2025 15:48
Co-authored-by: peaceh-nv <103117813+peaceh-nv@users.noreply.github.com>
Co-authored-by: jinyangyuan-nvidia <154768711+jinyangyuan-nvidia@users.noreply.github.com>
Signed-off-by: Yao Yao <lowsfer@users.noreply.github.com>
Signed-off-by: peaceh <103117813+peaceh-nv@users.noreply.github.com>
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
@jinyangyuan-nvidia
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7878 [ run ] triggered by Bot

Copy link
Collaborator

@ming-wei ming-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approved.

@jinyangyuan-nvidia jinyangyuan-nvidia enabled auto-merge (squash) June 6, 2025 09:29
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7878 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5692 completed with status: 'SUCCESS'

@jinyangyuan-nvidia jinyangyuan-nvidia merged commit 20d0649 into NVIDIA:main Jun 6, 2025
3 checks passed
@jinyangyuan-nvidia jinyangyuan-nvidia deleted the dev/sm120_xqa_mla branch June 6, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/NVIDIA/TensorRT-LLM/issues/4858

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy